search

dart-lang / pub-dev

The pub.dev website
https://pub.dev
BSD 3-Clause "New" or "Revised" License
782 stars 147 forks source link

Consider proxying images from the README.md file #2818

Open jonasfj opened 5 years ago

jonasfj commented 5 years ago

Proxying images from the README.md file displayed on the package page would mitigate user tracking by third-parties.

I'm not sure we need to cache, maybe caching a few minutes would be nice. But I don't think we have to be particularly concerned about third-parties tracking the number of requests, so long as we don't allow attaching cookies or expose the IP of the pub visitor. A proxy should probably only proxy URLs from our markdown, not arbitrary URLs from query-string.

Note. embedding images is useful for screenshots, etc.

Credits @sortie for suggesting this might be undesirable.

isoos commented 5 years ago

Wouldn't this expose us to further copyright and content hosting risk? Or will it be roughly the same?

jonasfj commented 5 years ago

Content hosting is a risk. Which is why we need to put it on a different domain.