dart-lang / pub-dev

The pub.dev website
https://pub.dev
BSD 3-Clause "New" or "Revised" License
769 stars 141 forks source link

Use package retry for retrying requests #7825

Open sigurdm opened 4 days ago

sigurdm commented 4 days ago

RetryClient does not retry receiving the body.

Sample stack trace:

at .IOClient.send ( package:http/src/io_client.dart:156 )
at .RetryClient.send ( package:http/retry.dart:115 )
at .BaseClient._sendUnstreamed ( package:http/src/base_client.dart:93 )
at Future.timeout.<fn>
at SearchClient.search.doCallHttpServiceEndpoint ( package:pub_dev/search/search_client.dart:66 )
at SearchClient.search.searchFn ( package:pub_dev/search/search_client.dart:76 )
at ._Entry.get ( package:neat_cache/neat_cache.dart:175 )
at .SearchClient.search ( package:pub_dev/search/search_client.dart:125 )
at .SearchAdapter._searchOrFallback ( package:pub_dev/package/search_adapter.dart:66 )
at .SearchAdapter.search ( package:pub_dev/package/search_adapter.dart:40 )
at ._packagesHandlerHtmlCore ( package:pub_dev/frontend/handlers/listing.dart:76 )
at RouterEntry.invoke.<fn> ( package:shelf_router/src/router_entry.dart:107 )
at .RouterEntry.invoke ( package:shelf_router/src/router_entry.dart:104 )
at .Router.call ( package:shelf_router/src/router.dart:184 )
at createAppHandler.<fn> ( package:pub_dev/frontend/handlers.dart:76 )
at _redirectLoopDetectorWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:93 )
at _cspHeaderWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:147 )
at _userAuthWrapper.<fn>.<fn> ( package:pub_dev/shared/handler_helpers.dart:243 )
at .AccountBackend.withBearerToken ( package:pub_dev/account/backend.dart:269 )
at _userAuthWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:242 )
at _requestContextWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:135 )
at _httpsWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:258 )
at _sanitizeRequestWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:226 )
at _logRequestWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:171 )
at .handleRequest ( package:shelf/shelf_io.dart:138 )
sigurdm commented 4 days ago
at .IOClient.send ( package:http/src/io_client.dart:156 )
at .AuthenticatedClient.send ( package:googleapis_auth/src/auth_http_utils.dart:41 )
at .RetryClient.send ( package:http/retry.dart:115 )
at .ApiRequester.request ( package:_discoveryapis_commons/src/api_requester.dart:69 )
at .ObjectsResource.get ( package:googleapis/storage/v1.dart:2355 )
at ._BucketImpl.read ( package:gcloud/src/storage_impl.dart:242 )
at BucketExt.readAsBytes.<fn> ( package:pub_dev/shared/storage.dart:130 )
at .RetryOptions.retry ( package:retry/retry.dart:131 )
at .TaskBackend._readFromBucket ( package:pub_dev/task/backend.dart:755 )
at ._Entry.get ( package:neat_cache/neat_cache.dart:175 )
at .TaskBackend.gzippedTaskResult ( package:pub_dev/task/backend.dart:849 )
at .TaskBackend.panaSummary ( package:pub_dev/task/backend.dart:919 )
at .ScoreCardBackend.getScoreCardData ( package:pub_dev/scorecard/backend.dart:147 )
at Future.wait.<fn>
at .loadPackagePageData ( package:pub_dev/frontend/handlers/package.dart:456 )
at ._handlePackagePage ( package:pub_dev/frontend/handlers/package.dart:301 )
at .packageVersionHandlerHtml ( package:pub_dev/frontend/handlers/package.dart:246 )
at RouterEntry.invoke.<fn> ( package:shelf_router/src/router_entry.dart:109 )
at .RouterEntry.invoke ( package:shelf_router/src/router_entry.dart:104 )
at .Router.call ( package:shelf_router/src/router.dart:184 )
at createAppHandler.<fn> ( package:pub_dev/frontend/handlers.dart:76 )
at _redirectLoopDetectorWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:93 )
at _cspHeaderWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:147 )
at _userAuthWrapper.<fn>.<fn> ( package:pub_dev/shared/handler_helpers.dart:243 )
at .AccountBackend.withBearerToken ( package:pub_dev/account/backend.dart:269 )
at _userAuthWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:242 )
at _requestContextWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:135 )
at _httpsWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:258 )
at _sanitizeRequestWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:226 )
at _logRequestWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:171 )
at .handleRequest ( package:shelf/shelf_io.dart:138 )
sigurdm commented 4 days ago
at .IOClient.send ( package:http/src/io_client.dart:156 )
at .AuthenticatedClient.send ( package:googleapis_auth/src/auth_http_utils.dart:41 )
at .RetryClient.send ( package:http/retry.dart:115 )
at .ApiRequester.request ( package:_discoveryapis_commons/src/api_requester.dart:69 )
at .ProjectsServiceAccountsResource.signBlob ( package:googleapis/iam/v1.dart:4066 )
at ._IamBasedUploadSigner.sign ( package:pub_dev/package/upload_signer_service.dart:118 )
at .UploadSignerService.buildUpload ( package:pub_dev/package/upload_signer_service.dart:81 )
at Future.wait.<fn>
at .TaskBackend.handleUploadResult ( package:pub_dev/task/backend.dart:615 )
at ._$PubApiRouter.<fn> ( package:pub_dev/frontend/handlers/pubapi.g.dart:1014 )
at RouterEntry.invoke.<fn> ( package:shelf_router/src/router_entry.dart:109 )
at .RouterEntry.invoke ( package:shelf_router/src/router_entry.dart:104 )
at .Router.call ( package:shelf_router/src/router.dart:184 )
at createAppHandler.<fn> ( package:pub_dev/frontend/handlers.dart:71 )
at _redirectLoopDetectorWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:93 )
at _cspHeaderWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:147 )
at _userAuthWrapper.<fn>.<fn> ( package:pub_dev/shared/handler_helpers.dart:243 )
at AccountBackend.withBearerToken.<fn> ( package:pub_dev/account/backend.dart:273 )
at ._ServiceScope._runScopeExitHandlers ( package:gcloud/service_scope.dart:241 )
at .AccountBackend.withBearerToken ( package:pub_dev/account/backend.dart:271 )
at _userAuthWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:242 )
at _requestContextWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:135 )
at _httpsWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:258 )
at _sanitizeRequestWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:226 )
at _logRequestWrapper.<fn> ( package:pub_dev/shared/handler_helpers.dart:171 )
at .handleRequest ( package:shelf/shelf_io.dart:138 )