search

dart-lang / sample-pop_pop_win

"Pop, Pop, Win!" is an implementation of Minesweeper in Dart.
https://dart-lang.github.io/sample-pop_pop_win/
BSD 3-Clause "New" or "Revised" License
149 stars 58 forks source link

packaging up to chrome install app #29

Closed adam-singer closed 11 years ago

sethladd commented 11 years ago

/cc @mangini

sethladd commented 11 years ago

Thanks Adam!

adam-singer commented 11 years ago

np, @kevmoo might want to cherry pick some of this. I have not looked this up, but what does installed chrome apps provide in terms of analytics @mangini ?

kevmoo commented 11 years ago

I'm getting on the merge right now. I'll likely do some sort of clever conditional compilation so it's easy to build for web or package w/ out a lot of manual steps.

Stay tuned.

On Fri, Dec 14, 2012 at 2:26 PM, adam notifications@github.com wrote:

np, @kevmoo https://github.com/kevmoo might want to cherry pick some of this. I have not looked this up, but what does installed chrome apps provide in terms of analytics @mangini https://github.com/mangini ?

— Reply to this email directly or view it on GitHubhttps://github.com/dart-lang/pop-pop-win/pull/29#issuecomment-11394766.

adam-singer commented 11 years ago

You also want to create a zip file of the package, that way its easy to upload to your developer dash board

kevmoo commented 11 years ago

I took a different approach, but I was heavily inspired by your patch.

See b88b4cb358c5852d4a14a8308a100a1cce06646c

Thanks, @financeCoding