search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.26k stars 1.58k forks source link

test.dart does not run on Windows #1206

Closed efortuna closed 9 years ago

efortuna commented 12 years ago

I suspect a big chunk of this is due to a lot of paths in the dart code "containing/strings/like/this".

DartBot commented 12 years ago

This comment was originally written by whe...@gmail.com

Which part doesn't run on Windows? I've only tested the vm parts, since I thought that was the only part with a Windows implementation. What should we prioritize? We have a solution planned, that does not involve backslashes.

efortuna commented 12 years ago

Sorry that was probably the world's vaguest bug report. You can also build the SDK (create_sdk), which generates a version of frog that is runnable on Windows. So, I was using test.py to run browser tests in Windows, in which case I used --component=webdriver, but this runs line 470 in test_suite.dart (executable = '$dartDir/tools/testing/run_selenium.py';) for example, which uses Unix slashes.

madsager commented 12 years ago

Set owner to @whesse. Added Accepted label.

whesse commented 12 years ago

I have tested the fix of eagerly changing all backslashes to slashes as soon as we get them from the Windows API, and it seems to be the best solution. There is no problem using slashes in inputs to the Win32 API - it converts them internally. I have also run tests with paths like 'c:/', '/', '/tmp/', etc., and they all work fine. We should eventually move it into the platform-specific implementation for Windows, and test that everything works.

The advantage of having a single path separator, '/', on all platforms and in URIs is really immense.

Added Started label.

efortuna commented 12 years ago

Added Area-Test label. Marked this as being blocked by #1263.

efortuna commented 12 years ago

This has been fixed a while ago. Our windows bots are running test.dart. I suspect we forgot to close it.

Added Fixed label.