search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.26k stars 1.58k forks source link

Library should have same public API across all platforms or have a different name #1332

Closed madsager closed 9 years ago

madsager commented 12 years ago

Currently the editor uses the dartc version of the coreimpl files for all configurations. This leads to issues when using the script configuration to run on the VM. The VM coreimpl files should be used in that case.

Currently, build_rcp.xml for the dart:io library contains a dummy ObjectArray class to get around this issue. Once the right version of coreimpl is used the dummy ObjectArray definition should be removed from the io library in the editor files.

danrubel commented 12 years ago

Was: Editor should use VM coreimpl library in the script configuration

Private methods and fields can vary across different implementations (e.g. VM, Frog, ...), but the public API for a given library bound to dart:<libname> (e.g. dart:core, dart:coreimpl, dart:io, ...) should be the same across all implementations on which it appears. If it has a different public API, then lets call it something different.

The same library with different public API on different platforms just confuses the user.

Removed Area-Editor label. Added Area-Language label. Changed the title to: "Library should have same public API across all platforms or have a different name".

danrubel commented 12 years ago

Issue #1418 has been merged into this issue.

gbracha commented 12 years ago

Re-assigning to library area.

Set owner to jjb@google.com. Removed Area-Language label. Added Area-Library, Accepted labels.

floitschG commented 11 years ago

With the patch structure we have a consistent interface now.

Set owner to @floitschG. Added Fixed label.