search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.08k stars 1.56k forks source link

dart:html KeyName docs refer to KeyEvent.getKeyboardIdentifier - doesn't exist #13621

Closed kevmoo closed 9 years ago

kevmoo commented 10 years ago

I'm a bit confused by this.

I'd love to get the KeyName from a KeyboardEvent (or KeyEvent).

Regardless, it seems the ref to the static getKeyboardIdentifier should be removed.

Pointers to other places where these names are returned would be goodness, though.

efortuna commented 10 years ago

On it. Check out https://codereview.chromium.org/23455033/. It just needs a few small tweaks (including making sure this is addressed) and then we can push it out the door.

Sorry for the delay. I've been firefighting bigger issues in the past few weeks that have prevented me from finishing this.

Set owner to @efortuna. Added this to the M7 milestone. Added Triaged label.

efortuna commented 10 years ago

Removed this from the M7 milestone. Added this to the M8 milestone.

efortuna commented 10 years ago

will be fixed with https://codereview.chromium.org/23455033/

Added Area-HTML label.

efortuna commented 10 years ago

Removed Priority-Unassigned label. Added Priority-Low label.

efortuna commented 10 years ago

Fixed with https://codereview.chromium.org//23455033 in r28321

Added Fixed label.