search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.23k stars 1.57k forks source link

Deletion of directory still corrupts Pub cache. #14992

Closed DartBot closed 9 years ago

DartBot commented 11 years ago

This issue was originally filed by mario.p...@gmail.com

This issue was already reported and closed as not reproducable, without being reopened, despite the bug still exists. Just stumbled over it again in Dart Plugin 0.8.10.r29803

Original issue: https://code.google.com/p/dart/issues/detail?id=10413

The step to reproduce it remained the same: In Eclipse, just delete a folder containing a "packages" symlink, for example the "web" folder in a new project. Every file of the dependencies in the pub cache gets deleted, only the subdirectories remain.

Is there any other information I can provide to hunt this bug down this time?

anders-sandholm commented 10 years ago

Added Area-Editor, Triaged labels.

clayberg commented 10 years ago

cc @scheglov. Set owner to @keertip. Added this to the 1.1 milestone. Removed Priority-Unassigned label. Added Priority-Medium label.

keertip commented 10 years ago

@ mario.ploner,

Are you running eclipse on windows?

DartBot commented 10 years ago

This comment was originally written by mario.p...@gmail.com

I do. Windows 7 64bit Professional, SP 1 Running Eclipse Kepler - Java Developer version, with only Dart, SVN and WST (for XML, HTML and CSS editing) as additional plugins installed.

Anything else I can provide? :)

keertip commented 10 years ago

Mario,

Pub uses junction points on Windows to create the symlinks. Unfortunately eclipse does not have support for junction points. We were able to override this in the editor and call out to the os to do the right thing while deleting the packages. But in the case of plugins, there is not much we can do - delete is just part of the eclipse framework.

Sorry, aware that this is not a satisfactory answer, but not sure what we can do in this case.

DartBot commented 10 years ago

This comment was originally written by mario.p...@gmail.com

Well, it's true that this is bad news. It's especially annoying that self-written libraries referenced by path are affected, too. :-/ Any chance this will somehow be fixed at some point in the future?

clayberg commented 10 years ago

Removed this from the 1.1 milestone. Added this to the 1.2 milestone.

clayberg commented 10 years ago

Removed this from the 1.2 milestone. Added this to the 1.3 milestone.

danrubel commented 10 years ago

Added OpSys-Windows, symlink labels.

keertip commented 10 years ago

Removed symlink label. Added Editor-Plugin label.

clayberg commented 10 years ago

Removed this from the 1.3 milestone. Added this to the 1.4 milestone.

kasperl commented 10 years ago

Removed this from the 1.4 milestone. Added this to the 1.5 milestone.

kasperl commented 10 years ago

Removed this from the 1.5 milestone. Added this to the 1.6 milestone.

kasperl commented 10 years ago

Removed this from the 1.6 milestone. Added Oldschool-Milestone-1.6 label.

kasperl commented 10 years ago

Removed Oldschool-Milestone-1.6 label.

sethladd commented 10 years ago

After review, we believe we can better address this issue by helping editors like sublime and webstorm provide great Dart support.

Sorry about that, unfortunately it doesn't look like we can do anything here.

Does this mean we can't use the Plugin on Windows?

Added NotPlanned label.

sethladd commented 10 years ago

Added Triaged label.

sethladd commented 10 years ago

Apologies. The Dart plugin for Eclipse is not supported. We will update our documentation.

Added NotPlanned label.

clayberg commented 10 years ago

Added this to the 1.6 milestone.