dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.21k stars 1.57k forks source link

[html] Incorrect Element.isContentEditable #16394

Open DartBot opened 10 years ago

DartBot commented 10 years ago

This issue was originally filed by Ilya.V...@gmail.com


co19/LibTest/html/Element/isContentEditable_ A01_t01 co19/LibTest/html/Element/isContentEditable_A02_t01

Getter returns false for explicitely set true value:

  x = new Element.html('<div contenteditable="true"></div>',       treeSanitizer: new NullTreeSanitizer());   Expect.isTrue(x.isContentEditable, 'explicit true');

Also true value is not properly inherited in a child:

  x = new Element.html('<div contenteditable="true"><span><pre></pre></span></div>',       treeSanitizer: new NullTreeSanitizer());   y = x.querySelector('pre');   Expect.isTrue(x.isContentEditable, 'inherited true');

lrhn commented 10 years ago

Added Area-HTML, Triaged labels.

giovannicandido commented 10 years ago

Separated tests for the problem: https://github.com/giovannicandido/darthtml-content-editable-test

giovannicandido commented 10 years ago

I don't know way, but my tests are passing in the code link above, but the not in https://github.com/angular/angular.dart/pull/436 .

kevmoo commented 10 years ago

Removed Area-HTML label. Added Area-Library, Library-Html labels.

alan-knight commented 9 years ago

I think this is a normal Chrome behaviour that the value isn't computed until the element actually exists. So the tests pass in the separated link because those tests actually add the element to the DOM. If I modify the co19 tests to add to the DOM, the test passes.


Set owner to @alan-knight. Added Started label.

sstrickl commented 5 years ago

This test is causing reds on the dart2js-strong-mac-x64-safari bot since build 3331, where it became non-flaky (it was failing flakily before that). I'm going to approve this failure for now, because there are other failures due to the new RegExp features (that aren't supported on Safari) and I want to approve those.