search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.19k stars 1.56k forks source link

merge r36502 to branches/1.4 to enable profiling on windows by default #18978

Closed kasperl closed 9 years ago

kasperl commented 10 years ago

This will allow people to use the Observatory on Windows without passing special flags to the VM.

The change r36502 enabled --profile by default on Windows (all non-Android platforms) and has been running without issues on the Windows build bots since May 22. It can be merged to the 1.4 release branch like this:

svn merge -c 36502 https://dart.googlecode.com/svn/branches/bleeding_edge branches/1.4

We may want to delay shipping this to the stable channel until we have a few days worth of coverage on the dev channel.

ricowind commented 10 years ago

Added Priority-High, Accepted labels.

ricowind commented 10 years ago

I get presubmit errors when uploading a cl with this merged: Running presubmit upload checks ... Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/profiler.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/heap.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/os_win.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/thread_interrupter.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/thread_interrupter_win.cc /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:1304: Is this a non-const reference? If so, make const or use a pointer: Array& default_values [runtime/references] [2] /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:1343: Is this a non-const reference? If so, make const or use a pointer: Array& default_values [runtime/references] [2] /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:1388: Is this a non-const reference? If so, make const or use a pointer: Array& default_values [runtime/references] [2] /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:2564: Is this a non-const reference? If so, make const or use a pointer: Array& default_parameter_values [runtime/references] [2] /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:2856: Is this a non-const reference? If so, make const or use a pointer: Array& default_parameter_values [runtime/references] [2] /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:5343: Is this a non-const reference? If so, make const or use a pointer: Array& default_values [runtime/references] [2] /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc:9509: Is this a non-const reference? If so, make const or use a pointer: Function& constructor [runtime/references] [2] Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/vm/parser.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/platform/thread_win.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/platform/thread_win.h Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/platform/thread_linux.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/platform/thread_macos.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/platform/thread_android.cc Done processing /usr/local/google/home/ricow/merge/1.4/dart/runtime/platform/thread.h

Presubmit ERRORS Failed cpplint check.

ricowind commented 10 years ago

Sorry, Ryans cl made the presubmit error

kasperl commented 10 years ago

Is there more stuff that needs merging, Anders? Should we wait with bringing this to branches/1.4 until the stuff in https://codereview.chromium.org/293133007/ is taken care of?

johnmccutchan commented 10 years ago

We still need to land one more bug fix to the windows stack walker.

andersjohnsen commented 10 years ago

I fix we need to pull over as well: r36623

kasperl commented 10 years ago

Fixed in r36641 (version 1.4.1).

Added Fixed label.