search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.26k stars 1.58k forks source link

Can't use CanvasGradient #1914

Closed DartBot closed 9 years ago

DartBot commented 12 years ago

This issue was originally filed by alban.au...@gmail.com

What steps will reproduce the problem? Setting a CanvasGradient to CanvasRenderingContext2D#fillStyle like this (see attached file):

import('dart:html');

// ... CanvasElement canvas = new Element.tag("canvas"); CanvasRenderingContext2D ctx = canvas.getContext("2d"); CanvasGradient gradient = ctx.createLinearGradient(0,0,0,200); // ... ctx.fillStyle = gradient;

What is the expected output? What do you see instead? Expected: no error Instead: the line "ctx.fillStyle = gradient;" generate a runtime error in dartium: FIXME:1Exception: String expected Stack Trace: 0. Function: 'CanvasRenderingContext2DImplementation.set:fillStyle' url: '/mnt/data/b/build/slave/dartium-lucid64-full/build/src/out/Release/obj/gen/webkit/bindings/dart/generated/dart/CanvasRenderingContext2DImplementation.dart' line:16 col:3  1. Function: 'CanvasRenderingContext2DWrappingImplementation.set:fillStyle' url: 'dart:htmlimpl' line:1490 col:53  2. Function: '::main' url: 'file:///home/alban/dev/dart/test/CanvasGradient-issue.html' line:9 col:19

What version of the product are you using? On what operating system? Dart Editor version 1.0.0.201202240929 Build 4577 on Ubuntu 11.10 Dartium/Chromium - Version 19.0.1050.0 (123195)

Attachment: CanvasGradient-issue.html (495 Bytes)

iposva-google commented 12 years ago

Added Area-Dartium, Triaged labels.

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

cc @jacob314. cc @rakudrama. cc @vsmenon. Removed Area-Dartium label. Added Area-Frog label.

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

Removed Area-Frog label. Added Area-UI label.

DartBot commented 12 years ago

This comment was originally written by levente...@gmail.com

It is reproducible with the following version as well: Dart Editor: Version 0.1.0.201203152021, Build 5549 Chromium: 19.0.1069.0 (Developer Build 126558 Mac OS X) OS: Mac OS X 10.7.3

    var gradient = context.createRadialGradient(bx - br/2, by - br/2, 0, bx, by, br);     gradient.addColorStop(0, '#­00ee00');     gradient.addColorStop(1, '#­555555');     // error is thrown: string expected...     context.fillStyle = gradient;

vsmenon commented 12 years ago

Removed Area-UI label. Added Area-DOM label.

vsmenon commented 12 years ago

Added this to the M1 milestone.

iposva-google commented 12 years ago

Removed Area-DOM label. Added Area-HTML label.

vsmenon commented 12 years ago

It looks like the type is marked "custom" in IDL. Reassigning to Dartium to fix there.

Removed Area-HTML label. Added Area-Dartium label.

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

I believe this has been fixed now, please, reopen if it's not the case.

Set owner to antonm@google.com. Added Fixed label.