dart-lang / sdk

The Dart SDK, including the VM, dart2js, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
9.94k stars 1.53k forks source link

petitparser dependency not found on pub upgrade #20811

Closed DartBot closed 9 years ago

DartBot commented 9 years ago

This issue was originally filed by @zoechi


I regularily get a stack trace from petitparser on pub upgrade. Petitparser isn't a direct dep in this project and I couldn't find a transitive dependency neither. Also pub cache repair doesn't list petitparser and I couldn't find a folder for it in ~/.pub-cache/hosted/pub.dartlang.org.

$ pub upgrade Resolving dependencies... (7.1s)   analyzer 0.22.4   args 0.12.0+2   barback 0.15.0+1   bignum 0.0.5   browser 0.10.0+2   bwu_datagrid 0.0.15 from path ../bwu_datagrid   bwu_fontawesome_iconset_svg 0.0.6+2   bwu_sparkline 0.0.4   bwu_utils 0.0.2   bwu_utils_browser 0.0.3   cipher 0.7.1   code_transformers 0.2.1   collection 1.0.0   core_elements 0.2.0+1   crypto 0.9.0   csslib 0.11.0+2   fixnum 0.9.0   html5lib 0.12.0   http_server 0.9.3   intl 0.11.6   logging 0.9.2   matcher 0.11.1   mime 0.9.0+3   observe 0.12.0   paper_elements 0.1.1+2   path 1.2.2 (1.3.0 available)   polymer 0.13.0+1   polymer_expressions 0.12.0+1   pool 1.0.1   quiver 0.18.2 (0.19.0-dev.3 available)   quiver_log 1.0.3   smoke 0.2.1   source_maps 0.10.0   source_span 1.0.0   stack_trace 1.0.2   string_scanner 0.1.0   template_binding 0.12.1   unittest 0.11.0+5   utf 0.9.0+1   uuid 0.4.0   watcher 0.9.3   web_components 0.6.0+1   yaml 2.0.1+1 No dependencies changed. Precompiling executables... Loading source assets... Loading polymer/src/build/mirrors_remover, observe and smoke/src/default_transformer transformers... (2.4s) Loading polymer transformers... (1.7s) Failed to precompile intl:generate_from_arb: Unhandled exception: Uncaught Error: Failure getting http://localhost:35018/packages/petitparser/petitparser.dart 404 Not Found Stack Trace:

­0 _asyncLoadError (dart:_builtin:339)

­1 _httpGet.<anonymous closure>.<anonymous closure> (dart:_builtin:128)

­2 _RootZone.runGuarded (dart:async/zone.dart:1009)

­3 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:390)

­4 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399)

­5 _BufferingStreamSubscription._close (dart:async/stream_impl.dart:290)

­6 _ForwardingStream._handleDone (dart:async/stream_pipe.dart:94)

­7 _handleDone (dart:async/stream_pipe.dart:162)

­8 _RootZone.runGuarded (dart:async/zone.dart:1009)

­9 _BufferingStreamSubscription._sendDone.sendDone (dart:async/stream_impl.dart:390)

­10 _BufferingStreamSubscription._sendDone (dart:async/stream_impl.dart:399)

­11 _DelayedDone.perform (dart:async/stream_impl.dart:614)

­12 _StreamImplEvents.handleNext (dart:async/stream_impl.dart:711)

­13 _PendingEvents.schedule.<anonymous closure> (dart:async/stream_impl.dart:671)

­14 _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:41)

­15 _asyncRunCallback (dart:async/schedule_microtask.dart:48)

­16 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:84)

­17 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:131)

­0 _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:820)

­1 _asyncRunCallbackLoop (dart:async/schedule_microtask.dart:41)

­2 _asyncRunCallback (dart:async/schedule_microtask.dart:48)

­3 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:84)

­4 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:131)

Precompiled polymer:new_element. Precompiled polymer:new_entry. Precompiled intl:extract_to_arb.

see also https://code.google.com/p/dart/issues/detail?id=20787

sigmundch commented 9 years ago

mmm... but intl already lists petitparser as a dev_dependency.

Natalie,Bob - are those supposed to change to be normal dependencies? It seems like if the binary can be pre-compiled, we shouldn't have to change them as normal package dependencies.


cc @nex3. cc @munificent.

nex3 commented 9 years ago

Natalie,Bob - are those supposed to change to be normal dependencies?

Yes. Anything in bin/ is considered a public executable, which means it uses the public dependencies. Package-internal executables should go in tool/ instead. See https://www.dartlang.org/tools/pub/package-layout.html#public-directories.

alan-knight commented 9 years ago

Fixed in 0.11.7


Added Fixed label.

DartBot commented 9 years ago

This issue has been moved to dart-lang/i18n#325.