search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.22k stars 1.57k forks source link

slow tests on windows #25940

Open sigmundch opened 8 years ago

sigmundch commented 8 years ago

Several tests seem to be flaking as timeouts on windows. Here is a list of tests I've marked as such:

# suite dart2js_extra
# in chrome:
class_test: Pass, Slow
consistent_codeUnitAt_error_test: Pass, Slow
closure_capture3_test: Pass, Slow
deferred_split_test: Pass, Slow
closure_capture5_test: Pass, Slow
conditional_test: Pass, Slow
constant_javascript_semantics2_test: Pass, Slow

# in ff:
consistent_index_error_string_test: Pass, Slow

# suite co19 in #ff
Language/Classes/Getters/type_object_t02: RuntimeError, Slow
Language/Classes/Abstract_Instance_Members/override_no_named_parameters_t06: Pass, Slow
Language/Classes/Constructors/Factories/return_type_t03: Pass, Slow
Language/Classes/Constructors/Factories/return_wrong_type_t02: Pass, Slow
Language/Classes/Constructors/Factories/return_type_t05: Pass, Slow
whesse commented 8 years ago

On linux, dart2js_extra/mirror_printer_test takes just about 1 minute, so it is marked as slow.

floitschG commented 7 years ago

If the type_object_t02.dart test timed out, it is probably flaky. It doesn't have any loop, or dependency on the browser. Did you (@sigmundch) check that the tests were slow in previous runs?

sigmundch commented 7 years ago

I don't recall, it's quite possible that I didn't.