search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.08k stars 1.56k forks source link

improve native effect summary in VttCue.line in dart:html #26029

Open sigmundch opened 8 years ago

sigmundch commented 8 years ago

Compiling a large app I noticed that all native elements were retained due to VttCue.line.

@jacob314

alan-knight commented 8 years ago

What do you mean by native effect summary? It has an "@Returns('num|String')". Does it also need a Creates annotation? Or is there something else it needs?

sigmundch commented 8 years ago

Yeah, I believe it need a @creates annotation too, probably @Creates("Null") is good enough (since num/String are everywhere.

I just noticed because I was doing something unrelated and run dart2js with --verbose. It mentioned that this was making us retain all native elements. It might be that after fixing this others will come up though.