Uri class query parameters contains '?' char

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.

https://dart.dev

BSD 3-Clause "New" or "Revised" License

10.08k stars 1.56k forks source link

Closed keertip closed 8 years ago

keertip commented 8 years ago

While working on uri manipulations, see query params contains a '?' char, which should not be the case.

Not sure in when the split and assignment is happening, but seeing test failures due to this.

mit-mit commented 8 years ago

CC @whesse

whesse commented 8 years ago

I think https://codereview.chromium.org/2167573002/ is a fix for this. I will land it, and cherry-pick it.

mit-mit commented 8 years ago

Closing as this was reverted. https://github.com/dart-lang/sdk/issues/26934 tracks bringing it back once test issues are resolved.

floitschG commented 8 years ago

Could you please provide an example.

lrhn commented 8 years ago

I have found the problem - it was in _SimpleUri.replace where the copy of the query includes the leading ?.