search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.2k stars 1.57k forks source link

hyperlinks not working for import directives #2981

Closed pq closed 9 years ago

pq commented 12 years ago

To repro:

   open lib/compiler/dart2.js    command hover over any of the imports

You should see a stacktace like so:

!ENTRY org.eclipse.ui 4 0 2012-05-09 14:57:32.846 !MESSAGE Unhandled event loop exception !STACK 0 org.eclipse.core.runtime.AssertionFailedException: null argument:     at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)     at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlink.<init>(DartElementHyperlink.java:41)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlinkDetector.internalDetectHyperlinks(DartElementHyperlinkDetector.java:98)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlinkDetector.detectHyperlinks(DartElementHyperlinkDetector.java:47)     at org.eclipse.ui.texteditor.HyperlinkDetectorRegistry$HyperlinkDetectorDelegate.detectHyperlinks(HyperlinkDetectorRegistry.java:80)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:286)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:258)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseMove(HyperlinkManager.java:462)     at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:211)     at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)     at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)     at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)     at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)     at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2709)     at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2671)     at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2505)     at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:685)     at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)     at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:678)     at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)     at com.google.dart.tools.deploy.DartIDEApplication.start(DartIDEApplication.java:84)     at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)     at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)     at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)     at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)     at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:616)     at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)     at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)     at org.eclipse.equinox.launcher.Main.run(Main.java:1410)     at org.eclipse.equinox.launcher.Main.main(Main.java:1386) null word region

!ENTRY org.eclipse.ui 4 0 2012-05-09 14:57:32.985 !MESSAGE Unhandled event loop exception !STACK 0 org.eclipse.core.runtime.AssertionFailedException: null argument:     at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)     at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlink.<init>(DartElementHyperlink.java:41)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlinkDetector.internalDetectHyperlinks(DartElementHyperlinkDetector.java:98)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlinkDetector.detectHyperlinks(DartElementHyperlinkDetector.java:47)     at org.eclipse.ui.texteditor.HyperlinkDetectorRegistry$HyperlinkDetectorDelegate.detectHyperlinks(HyperlinkDetectorRegistry.java:80)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:286)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:258)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseMove(HyperlinkManager.java:462)     at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:211)     at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)     at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)     at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)     at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)     at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2709)     at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2671)     at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2505)     at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:685)     at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)     at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:678)     at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)     at com.google.dart.tools.deploy.DartIDEApplication.start(DartIDEApplication.java:84)     at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)     at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)     at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)     at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)     at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:616)     at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)     at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)     at org.eclipse.equinox.launcher.Main.run(Main.java:1410)     at org.eclipse.equinox.launcher.Main.main(Main.java:1386) null word region

!ENTRY org.eclipse.ui 4 0 2012-05-09 14:57:33.078 !MESSAGE Unhandled event loop exception !STACK 0 org.eclipse.core.runtime.AssertionFailedException: null argument:     at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)     at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlink.<init>(DartElementHyperlink.java:41)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlinkDetector.internalDetectHyperlinks(DartElementHyperlinkDetector.java:98)     at com.google.dart.tools.ui.internal.text.editor.DartElementHyperlinkDetector.detectHyperlinks(DartElementHyperlinkDetector.java:47)     at org.eclipse.ui.texteditor.HyperlinkDetectorRegistry$HyperlinkDetectorDelegate.detectHyperlinks(HyperlinkDetectorRegistry.java:80)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:286)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.findHyperlinks(HyperlinkManager.java:258)     at org.eclipse.jface.text.hyperlink.HyperlinkManager.mouseMove(HyperlinkManager.java:462)     at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:211)     at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)     at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1258)     at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3588)     at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3209)     at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2709)     at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2671)     at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2505)     at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:685)     at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)     at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:678)     at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)     at com.google.dart.tools.deploy.DartIDEApplication.start(DartIDEApplication.java:84)     at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)     at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)     at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)     at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)     at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)     at java.lang.reflect.Method.invoke(Method.java:616)     at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)     at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)     at org.eclipse.equinox.launcher.Main.run(Main.java:1410)     at org.eclipse.equinox.launcher.Main.main(Main.java:1386)

danrubel commented 12 years ago

Set owner to @bwilkerson.

bwilkerson commented 12 years ago

Added Started label.

bwilkerson commented 12 years ago

http://codereview.chromium.org/10447034/

Added Fixed label.