search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.22k stars 1.57k forks source link

Document how to update expectations when they don't match #29947

Open peter-ahe-google opened 7 years ago

peter-ahe-google commented 7 years ago

On one day, I've gotten the same question from two different people: "how do I update expectations in pkg/front_end/testcases?"

We should document this.

/cc @kmillikin @jensjoha

kmillikin commented 7 years ago

Thanks for filing the issue. The tree shaker expectations have a line like:

DO NOT EDIT -- this file is autogenerated ---

at the top. That would be a good place to put instructions for how to generate the file, with the advantage that since it is autogenerated you only have to update the instructions in one place (and regenerate the expectations) if the instructions change.