search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.3k stars 1.59k forks source link

frontend tests failing on windows: "Error: SDK root directory not found: e:/." #31902

Open athomas opened 6 years ago

athomas commented 6 years ago

These tests fail on windows: front_end/test/kernel_generator_test: RuntimeError front_end/test/mixin_export_test: RuntimeError front_end/test/src/incremental/hot_reload_e2e_test: RuntimeError front_end/test/summary_generator_test: RuntimeError front_end/test/whole_program_test: RuntimeError

The all have a variation of this error in the logs: Error: SDK root directory not found: e:/.

Build: https://chromium-swarm.appspot.com/task?id=3afd7e93fb7a8a10 Log: https://logs.chromium.org/v/?s=dart%2Fled%2Fathom_google.com%2F031f85f65c6387b3e898de770db079c856e047f14d2aa40235171b60557feeeb%2F%2B%2Fsteps%2Ffront-end_tests%2F0%2Fstdout

Related to #31707

whesse commented 6 years ago

The following tests are still failing on windows, and are now marked with RuntimeError in the status file pkg/pkg.status in the runtime vm, system windows section:

front_end/test/whole_program_test front_end/test/fasta/bootstrap_test

The errors are both about windows paths and the drive letters c: or e: starting them:

whole program test: Running: E:\b\build\slave\analyzer-win7-release-strong-be\build\sdk\out\ReleaseX64\dart-sdk\bin\dart.exe --packages=E:\b\build\slave\analyzer-win7-release-strong-be\build\sdk.packages -c E:\b\build\slave\analyzer-win7-release-strong-be\build\sdk\pkg\front_end\tool_fasta\compile.dart --platform=E:\b\build\slave\analyzer-win7-release-strong-be\build\sdk\out\ReleaseX64\dart-sdk\lib_internal\vm_platform.dill --output=C:\Users\CHROME~2\AppData\Local\Temp\whole_programe63eddd2-fb9a-11e7-b4df-005056030213\hello.dart.dill --packages=E:\b\build\slave\analyzer-win7-release-strong-be\build\sdk.packages --verify C:\Users\CHROME~2\AppData\Local\Temp\whole_programe63eddd2-fb9a-11e7-b4df-005056030213\hello.dart Output: c:: Error: Unexpected input: c:
ExitCode: 1 Took: 0:00:04.703281 stderr: Unhandled exception: Compilation of hello.dart failed.

bootstrap_test: Unhandled exception: FileSystemException(uri=e:.packages; message=StandardFileSystem only supports file: and data: URIs)

0 StandardFileSystem.entityForUri (package:front_end/src/api_prototype/standard_file_system.dart:31:7)

1 ProcessedOptions._findPackages.checkInDir (package:front_end/src/base/processed_options.dart:474:28)

#2 ProcessedOptions._findPackages (package:front_end/src/base/processed_options.dart:479:37) #3 ProcessedOptions._getPackages (package:front_end/src/base/processed_options.dart:422:30) #4 ProcessedOptions.getUriTranslator (package:front_end/src/base/processed_options.dart:355:28) #5 CompileTask.buildOutline (file:///E:/b/build/slave/pkg-win7-release-be/build/sdk/pkg/front_end/tool/_fasta/entry_points.dart:131:51) #6 CompileTask.compile (file:///E:/b/build/slave/pkg-win7-release-be/build/sdk/pkg/front_end/tool/_fasta/entry_points.dart:163:39)
peter-ahe-google commented 6 years ago

I think whole_program_test is failing due to: https://github.com/dart-lang/sdk/blob/4e56b7a92b0071b9f49212d43a900627c66ba1cb/pkg/front_end/tool/_fasta/command_line.dart#L302

https://github.com/dart-lang/sdk/blob/4e56b7a92b0071b9f49212d43a900627c66ba1cb/pkg/front_end/tool/_fasta/command_line.dart#L332

These places also need to use new Uri.file.

peter-ahe-google commented 6 years ago

Probably same problem in bootstrap_test.