Support for 'Aspirational' Hot-Reload Cases

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.

https://dart.dev

BSD 3-Clause "New" or "Revised" License

10.1k stars 1.56k forks source link

Support for 'Aspirational' Hot-Reload Cases #32981

Open bkonyi opened 6 years ago

bkonyi commented 6 years ago

The following tests are marked Fail, Crash as they test use cases for hot-reload that are not currently supported by the VM:

[ ] cc/IsolateReload_PendingConstructorCall_AbstractToConcrete
[ ] cc/IsolateReload_PendingConstructorCall_ConcreteToAbstract
[ ] cc/IsolateReload_PendingStaticCall_DefinedToNSM
[ ] cc/IsolateReload_PendingStaticCall_NSMToDefined
[ ] cc/IsolateReload_PendingUnqualifiedCall_InstanceToStatic
[ ] cc/IsolateReload_PendingUnqualifiedCall_StaticToInstance

cc @rmacnak-google

crelier commented 5 years ago

Note that these tests are actually marked as Fail, Crash, and not as SkipByDesign.

rmacnak-google commented 5 years ago

To clarify, these tests all hit defects in the VM. Fixing the VM to support these cases requires substantial changes to the current compilation strategy. PendingConstructorCall requires we move allocation to the construction functions instead of their callers. PendingStaticCall requires we handle static NSM out of line. PendingUnqualifiedCall requires every static function to take an unused placeholder argument for the receiver.