search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.26k stars 1.58k forks source link

Categorize tests that fail on IE #3304

Closed kasperl closed 9 years ago

kasperl commented 12 years ago

Needs investigation.

kasperl commented 12 years ago

Removed Priority-Medium label. Added Priority-High, Accepted labels.

kasperl commented 12 years ago

Set owner to @kasperl.

kasperl commented 12 years ago

I've briefly looked into these failures. Maybe I'm wrong, but it looks like we never ran the samples tests on frog because at least swarm doesn't seem to run correctly on IE (needs applicationCache support).

My current theory is that most of the timeouts on the language tests are due us crashing while dealing with thrown exceptions (so the test runner framework never gets the signal that we're done), but I think we've improved this with the recent changes to unwrapException and objectToString.

Early next week, I'll run through the tests and try to stop skipping them again.

cc @rakudrama.

kasperl commented 12 years ago

We now do not skip any tests, but a bunch of tests are still failing. They should be categorized.

Removed Priority-High label. Added Priority-Medium label. Changed the title to: "Categorize tests that fail on IE".

vsmenon commented 12 years ago

A couple tests marked fail with this bug (lib/view/view_test and lib/layout/layout_test) now pass on IE and Safari after a fix (https://chromiumcodereview.appspot.com/10544076/diff/8001/samples/ui_lib/view/view.dart). swarm_test also runs on Safari.

I hit this running the Swarm app itself with Dart2JS on Safari. The fix makes it work. It's surprising to me that Swarm ever ran with Frog on Safari (it did at some point). Perhaps a difference in short circuited &&?

efortuna commented 12 years ago

Just fixed 10 IE tests by expanding the NoSuchMethodException detection (IE prints a slightly different error message) https://chromiumcodereview.appspot.com//10882004

kasperl commented 12 years ago

I think we have a good enough grip on the IE failures now. Marking this as fixed (the categorization part).

Added Fixed label.