have the VM's service protocol support a way to get recent historical data for memory usage

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.

https://dart.dev

BSD 3-Clause "New" or "Revised" License

10.24k stars 1.57k forks source link

have the VM's service protocol support a way to get recent historical data for memory usage #34584

Open ghost opened 6 years ago

ghost commented 6 years ago

@B3rn475 commented on Sep 15, 2017, 11:06 PM UTC:

Currently in the Flutter Observatory Memory Dashboard the graph samples are fixed at a 2 minutes window, everything outside that window is dropped.

It would be interesting to store samples indefinitely and allow the developer to:

Choose the size of the window (1 minute, 2 minutes, 5 minutes, 10 minutes, 20 minutes, ...).
See old values by moving the window back in time.

This issue was moved by devoncarew from flutter/flutter#12122.

ghost commented 6 years ago

@zoechi commented on Aug 31, 2018, 7:37 PM UTC:

@Hixie what is the reason you removed the observatory label? (there were a few others where you did this) Looks like it's about Observatory. (don't know how to triage)

ghost commented 6 years ago

@Hixie commented on Sep 25, 2018, 7:35 PM UTC:

@zoechi It was part of an effort to clean up our labels. There were very few things with that label so I removed the label from our list of labels. Really this probably belongs in the IDE issue list? cc @devoncarew

ghost commented 6 years ago

@devoncarew commented on Sep 25, 2018, 8:27 PM UTC:

I think we'll still want something like this, but likely done as an enhancement to the VM's service protocol. Perhaps best to re-purpose, and instead track at the sdk repo.

devoncarew commented 6 years ago

I don't know if we have service protocol specific labels; @a-siva; I used vm-debugger.