kernel_sdk.dart is hiding errors

dart-lang / sdk

The Dart SDK, including the VM, dart2js, core libraries, and more.

https://dart.dev

BSD 3-Clause "New" or "Revised" License

9.98k stars 1.54k forks source link

kernel_sdk.dart is hiding errors #37117

Open sigmundch opened 5 years ago

sigmundch commented 5 years ago

The script kernel_sdk.dart used to build the DDC platform dill file is not failing when the CFE reports errors.

We should:

[x] fix the current errors (done!)
[x] ensure the script exits with an error code if errors were found (cl/105461)
[ ] eventually split the script, so we build the .dill file using the same scripts that we used for all other targets (compile_platform.dart), and then build the .js as a separate build step.

vsmenon commented 5 years ago

We should just remove this in favor of calling dartdevc directly from GN.

fyi @jonahwilliams - looks like flutter is using a copy of this.

sigmundch commented 5 years ago

agree - and use the GN compile_platform macro to generate the sdk outline that we want to ship externally.

FWIW, the fix to stop hiding the error in kernel_sdk might be pretty small and might be worth doing anyways before we migrate things.

jonahwilliams commented 5 years ago

Just point me to the replacement and I can make sure that rolls into the engine correctly.

sigmundch commented 5 years ago

Two CLs are out for review.

https://dart-review.googlesource.com/c/sdk/+/105404 - a fix for the ddc sdk (it currently has errors)
https://dart-review.googlesource.com/c/sdk/+/105461 makes kernel_sdk exit with a non-zero status if an error was encountered.

I'm guessing the former will roll automatically, but if you have a copy of kernel_sdk.dart, the latter CL will need to be copied on your end.

sigmundch commented 5 years ago

@vsmenon - in case it is helpful, I found this very old CL around: https://dart-review.googlesource.com/c/sdk/+/56297/

That CL did 3 changes, 2 of which are no longer relevant:

it moved the libraries.json files (that has already landed separately)
it split kernel_sdk to only produce the .js files and not the .dill
moved generation of the .dill to GN

My guess is that you'll drop the changes to the kernel_sdk, but use the GN changes to create the sdk outline with the same tool chain as all other tools, and separately invoke dartdevc to produce dart_sdk.js.