search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.05k stars 1.55k forks source link

GitHub code navigation support #37418

Open johnpryan opened 5 years ago

johnpryan commented 5 years ago

GitHub uses github.com/github/semantic for code navigation (beta). It would be great to have Dart on the list of supported languages.

bwilkerson commented 5 years ago

Agreed. Unfortunately the docs for semantic are not very encouraging:

... adding support for a new language is a nontrivial amount of work.

There's work being done at Microsoft to add a Kythe-like language service to support similar sorts of tooling (https://code.visualstudio.com/blogs/2019/02/19/lsif). This would be much easier to implement because we wouldn't need to re-write everything. I don't know whether GitHub has any plans to support this protocol.

davidmorgan commented 4 years ago

package:pedantic recommends omit_local_variable_types in large part because google internal tools make it easy enough to find types by following cross references.

It doesn't look like adding code navigation support is an easy thing to do; it does seem like it could give a lot of value. Please count 'reduces difference between external and internal development' as part of that value :)

gnprice commented 1 year ago

Related newer issue: https://github.com/dart-lang/sdk/issues/50523

It sounds like what GitHub now asks for in order to support a given language is a tree-sitter parser for it, which is somewhat more encouraging.