search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.23k stars 1.57k forks source link

Remove unused DDC configuration #37827

Open natebosch opened 5 years ago

natebosch commented 5 years ago

trackProfile looks unused and we can drop it - this was mostly useful for devs migrating from non-strong code and was enabled with the now nonexistant plugin.

ignoreAllErrors is also unused.

trapRuntimeErrors is set by test_runner, but it's set to the default.

vsmenon commented 5 years ago

trackProfile profiles hot dynamic calls. Still potentially useful if we can figure out a good way to surface it. I sometimes flip by hand (dart.__trackProfile = true on console) and dump the map.

I don't think the other two are particularly useful anymore.

natebosch commented 5 years ago

Sounds like we can at least get rid of the globalState.ddcSettings handling for trackProfile if you typically set it manually.

Does anyone else use this? Do we have a document outlining how to use it?

vsmenon commented 5 years ago

I believe it's only used by the deprecated DDC extension: @alan-knight ?