dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.25k stars 1.58k forks source link

co19_2/LanguageFeatures/Triple-Shift/Constants_A01_t08/none fails on bots #40582

Closed scheglov closed 4 years ago

scheglov commented 4 years ago

See the log.

--- Command "dart2analyzer" (took 16ms):
DART_CONFIGURATION=ReleaseX64 xcodebuild/ReleaseX64/dart-sdk/bin/dartanalyzer --enable-experiment=triple-shift --ignore-unrecognized-flags --packages=/b/s/w/ir/cache/builder/sdk/.packages --format=machine --no-hints /b/s/w/ir/cache/builder/sdk/xcodebuild/ReleaseX64/generated_tests/co19_2/LanguageFeatures/Triple-Shift/Constants_A01_t08_none.dart

exit code:
1

stderr:
ERROR|SYNTACTIC_ERROR|MISSING_IDENTIFIER|/b/s/w/ir/cache/builder/sdk/xcodebuild/ReleaseX64/generated_tests/co19_2/LanguageFeatures/Triple-Shift/Constants_A01_t08_none.dart|27|37|1|Expected an identifier.
ERROR|COMPILE_TIME_ERROR|INVALID_CONSTANT|/b/s/w/ir/cache/builder/sdk/xcodebuild/ReleaseX64/generated_tests/co19_2/LanguageFeatures/Triple-Shift/Constants_A01_t08_none.dart|27|37|0|Invalid constant value.

--- Re-run this test:
python tools/test.py -n analyzer-asserts-mac co19_2/LanguageFeatures/Triple-Shift/Constants_A01_t08/none

======================================================

The test was failing for me locally, until I rebuilt the SDK. But I'd expect that bots do rebuild.

It looks that analyzer disregards --enable-experiment=triple-shift, maybe because it finds package config with language version?

whesse commented 4 years ago

This may be a problem with builders not rebuilding something they should, so the build process is missing a dependency maybe?

whesse commented 4 years ago

40532 explains this failure. I don't know why these failures aren't attributed to the correct commit, looking into it.