search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.09k stars 1.56k forks source link

Many new dart2js_extra tests on nndb changing from Timeout to pass/error #41507

Open whesse opened 4 years ago

whesse commented 4 years ago

A new builder has been added that runs dart2js_extra tests on dart2js in strong nndb mode. A whole lot of these tests have stopped timing out on dart2js on the builder dart2js-nnbd-linux-x64-chrome on commits since the one that introduced these tests: https://github.com/dart-lang/sdk/commit/4aa896464a4860f2e8e35c9f31b4742aa3ed3dc1

Those that have an unexpected failure on the tests are showing up as new failures when they stop timing out. I think most of these failures would be known already on other configurations, but can't be sure.

Someone on the dart for web group should verify what is happening, and what action should be taken.

@joshualitt

sigmundch commented 4 years ago

We want to approve all failures at this time, and we'll triage and fix iteratively.

In general, we are noticing a lot of timeouts on this bot. Possibly a combination of using nnbd + enable asserts on the VM.

@whesse @athomas - are there small steps we could take to mitigate this on our infrastructure? Two ideas come to mind:

@a-siva @rmacnak-google - I was wondering if you were aware of any other performance issues specific of enabling assertions? The dart2js-nnbd bot is considerably slower and we hit timeouts very frequently. Ryan - we also noticed that after this commit 1e34ad08eedf8b617419051117e73d212370bef3 our nnbd bot has been red ever since always due to flaky timeouts. (see the history here: https://ci.chromium.org/p/dart/builders/ci.sandbox/dart2js-nnbd-linux-x64-chrome?limit=100).

athomas commented 4 years ago

I would suggest to start with a CL that raises the timeout in the test matrix configuration. There are several other configurations that already do that so that change should be fairly straightforward.

On Wed, Apr 15, 2020, 17:23 sigmundch notifications@github.com wrote:

We want to approve all failures at this time, and we'll triage and fix iteratively.

In general, we are noticing a lot of timeouts on this bot. Possibly a combination of using nnbd + enable asserts on the VM.

@whesse https://github.com/whesse @athomas https://github.com/athomas

  • are there small steps we could take to mitigate this on our infrastructure? Two ideas come to mind:

    • provide a bigger timeout for this bots
    • distinguish compiler timeout vs runtime timeout - this would help us triage whether the timeout is more likely a VM issue or a dart2js issue.

@a-siva https://github.com/a-siva @rmacnak-google https://github.com/rmacnak-google - I was wondering if you were aware of any other performance issues specific of enabling assertions? The dart2js-nnbd bot is considerably slower and we hit timeouts very frequently. Ryan - we also noticed that after this commit 1e34ad0 https://github.com/dart-lang/sdk/commit/1e34ad08eedf8b617419051117e73d212370bef3 our nnbd bot has been red ever since always due to flaky timeouts. (see the history here: https://ci.chromium.org/p/dart/builders/ci.sandbox/dart2js-nnbd-linux-x64-chrome?limit=100 ).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dart-lang/sdk/issues/41507#issuecomment-614105269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEYRJB5HBSMCO7DXIIO2A4DRMXGPNANCNFSM4MIRAKGA .