search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.26k stars 1.58k forks source link

Triple head (HHH) bot should avoid invalidating the Flutter binary cache #41588

Open dnfield opened 4 years ago

dnfield commented 4 years ago

Currently, the triple head bot overwrites files in the flutter/bin/cache folder to run tests against custom built artifacts: https://dart.googlesource.com/recipes/+/master/recipes/dart/flutter_engine.py#191

This means that any tests that Flutter adds to validate its cache will fail on that bot.

Ideally, Flutter could keep these tests as is without guards for the HHH bot. There should be a way to run flutter/dev/bots/test.dart with a local engine, and if not, we should make sure it works for HHH's needs.

@athomas @christopherfujino @jonahwilliams @alexmarkov @aam

dnfield commented 4 years ago

See, for example, discussions at https://github.com/flutter/flutter/pull/55223 and https://github.com/flutter/flutter/pull/55057