search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.21k stars 1.57k forks source link

co19/LibTest/io/Process/run_A01_t03 failing on Windows #44422

Open dcharkes opened 3 years ago

dcharkes commented 3 years ago

There are new test failures on [dartdevc] Containerizing top-level variables to improve stepping times....Reland "[cfe] Improve encoding of set/list literals for unified collections".

Commit in that range that touched the windows process in the VM:

(Need to bisect manually, because the bots don't.)

The tests

co19/LibTest/io/Process/run_A01_t03 RuntimeError (expected Pass)
co19/LibTest/io/Process/run_A01_t03 RuntimeError (expected Pass)

are failing on configurations

dartk-strong-win-debug-x64
dartk-strong-win-release-ia32
dartk-strong-win-release-x64
dartk-weak-asserts-win-debug-x64
dartk-weak-asserts-win-release-ia32
dartk-weak-asserts-win-release-x64

cc @askeksa-google who started bisecting. cc @a-siva who reviewed the suspect CL.

sstrickl commented 1 year ago

We're seeing it fail again on

dartk-strong-win-release-ia32
dartk-weak-asserts-win-release-ia32

example logs

So at some point it started passing again and has now flipped back.