dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.26k stars 1.58k forks source link

heap snapshot format is broken by unboxed fields #45599

Open mraleph opened 3 years ago

mraleph commented 3 years ago

Heap snapshot serializer assumes that pointers form a continous region inside the object, but this is not the case with unboxed fields.

This causes a skew between field names and outgoing references when viewing profiles.

/cc @mkustermann @rmacnak-google @bkonyi

a-siva commented 3 years ago

/cc @bkonyi