search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.3k stars 1.59k forks source link

The Language Server doesn't allow for IDE diffs #45657

Open feinstein opened 3 years ago

feinstein commented 3 years ago

As pointed out in this IntelliJ issue, the language server doesn't allow for an IDE, like Android Studio, to provide in-depth diff views.

IntelliJ has Github pull-request reviews built-in, which means we can see from the IDE what changed, make comments and, especially, navigate the code itself to understand the impact of each change.

Without diffs, we can't navigate the changes, or easily measure impact. Also we can't even have proper code highlighting. This hinders the streamlined experience that we all look for, and also makes the dart workflow harder than other languages.

I know this is not a simple ask, but if the Dart Team could partner up with IntelliJ, and look for ways to make better integrations with the language server, the whole Dart experience will jump in quality, making a lot of us don't feel like we are missing something by adopting Dart.

image

This image illustrates the issue, where on the left everything is just plain and simple text, while on the right we have proper IDE assistance.

This is the best scenario, just a local diff. On Pull Requests reviews both sides are plain text with no highlights.

bwilkerson commented 3 years ago

@alexander-doroshko @jwren @stevemessick

feinstein commented 3 years ago

Hi guys!

Does anyone has an idea on how we can improve the language server, so IntelliJ IDEA won't lose this diff functionality on Dart?