search

dart-lang / sdk

The Dart SDK, including the VM, dart2js, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
9.94k stars 1.53k forks source link

Failures on [vm] Refactor compilation of runtime calls. #48646

Closed alexmarkov closed 2 years ago

alexmarkov commented 2 years ago

There are new test failures on Update clang and gn to match Fuchsia....Handle another case of replacing a named constructor.

The tests

vm/dart_2/write_barrier_double_register_clobber_test RuntimeError (expected Pass)
vm/dart_2/write_barrier_simd_register_clobber_test RuntimeError (expected Pass)

are failing on configurations

dartkp-linux-debug-simarm-crossword
dartkp-linux-release-simarm
dartkp-linux-release-simarm-crossword

These tests were introduced in 67f93d3840981ad81b44bceb0b755fbab50f13bd and immediately started failing on AOT/simarm. @rmacnak-google Could you please take a look?

sstrickl commented 2 years ago

Also approving the overnight failures on

dartkp-strong-linux-debug-simarm-crossword
dartkp-strong-linux-release-simarm-crossword
dartkp-weak-asserts-linux-debug-simarm-crossword
dartkp-weak-asserts-linux-release-simarm-crossword
rmacnak-google commented 2 years ago

https://dart-review.googlesource.com/c/sdk/+/238301