search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.27k stars 1.58k forks source link

[Extension type] Syntax highlighters implementation #49734

Open itsjustkevin opened 2 years ago

itsjustkevin commented 2 years ago

Cobbling together the list from past issues:

eernstg commented 1 year ago

Please note that this feature has been renamed: It is now the 'inline class' feature.

DanTup commented 1 year ago

@itsjustkevin do you have a script to create issues like this one? I was adding some items to the server list and wasn't sure whether the syntax highlighting (that doesn't come from the server) is recorded anywhere?

itsjustkevin commented 1 year ago

@DanTup I need to work on that script again, it is currently broken due to some bad graphql calls but I would be happy to add the additions you mention here!

This is on my todo list for the near future.

DanTup commented 1 year ago

Out of interest, is the script public? (I'm curious what it does/where it gets data from).

I've removed the textmate grammar (the dart-syntax-highlight repo) from my changes to the servers features since it doesn't really belong there, but it'd be good to include them in your script (or manual process) for new features.

I presume the script pulls the analysis server items directly from https://github.com/dart-lang/sdk/blob/main/pkg/analysis_server/doc/process/new_language_feature.md (and there isn't another copy of that list somewhere)?

bwilkerson commented 1 year ago

I would love it if the script populated the list automatically, but IIRC it's always just created an empty issue and I've been the one copying the list into the issue.

itsjustkevin commented 1 year ago

@DanTup I have not even gone through that depth of inception. My script only generates the basic issues under the umbrella issues.

@bwilkerson I do see value in compiling a list and further updating these template issues to have their own child issues.

bootleg scripts can be viewed here 🙂.

domesticmouse commented 1 year ago

@johnpryan and @devoncarew are maintaining this for DartPad now.

FYI @RedBrogdon