search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.03k stars 1.55k forks source link

New --add-readonly-data-symbols test failing on simulated architectures and Linux cross-compilation to arm64 #50071

Open sstrickl opened 1 year ago

sstrickl commented 1 year ago

There are new test failures on [dart2js] Fix node tracer migration...[vm/ffi] Support DynamicLibrary.process() on Windows.

The tests

vm/dart/use_add_readonly_data_symbols_flag_test RuntimeError (expected Pass)
vm/dart_2/use_add_readonly_data_symbols_flag_test RuntimeError (expected Pass)

are failing on configurations

dartkp-linux-debug-simriscv64
dartkp-linux-release-arm64
dartkp-strong-linux-release-simarm64
dartkp-weak-asserts-linux-debug-simarm-crossword
dartkp-weak-asserts-linux-release-simarm-crossword
dartkp-weak-asserts-linux-release-simarm64

The failures on simulated architectures is due to the fact that the test is attempting to test assembly output on those architectures.

Unsure why the failure on dartkp-linux-release-arm64, am looking into that now.

sstrickl commented 1 year ago

Looking at the results of the cross-compliation failure after ensuring the symbol was printed before any expects makes it clear what the logic error in the test is in this case, creating a CL to fix that.