search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.31k stars 1.59k forks source link

Add `flutter_test` fix tests to `analyze_flutter_flutter.sh` #51979

Open pdblasi-google opened 1 year ago

pdblasi-google commented 1 year ago

As part of flutter #123154, we're adding support for dart fix to the flutter_test library. Currently, analyze_flutter_flutter.sh only runs the fix tests for the main flutter package, but it may be worth adding the flutter_test fix tests to the script.

srawlins commented 4 months ago

I don't think there's anything to do here on the Dart / analyzer side...

pdblasi-google commented 4 months ago

The analyze_flutter_flutter.sh file is part of the dart-lang repo and is used to validate that changes to the analyzer doesn't break existing dart fix functionality.

This ticket was written when we added dart fix functionality to the flutter_test repo, and was intended to do something similar to this commit, which looks like it was reverted for some reason.

Just judging by the commit message of this later commit, it looks like this ticket might be irrelevant now, but I don't have enough context to say for sure.

@whesse and/or @Piinks may be able to provide more/better context.

srawlins commented 4 months ago

Ah I see. I had forgotten that.