search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.27k stars 1.58k forks source link

Failures on add Builder.report method and Diagnostic class to support macros sending diagnostics...Issue 53287. Include enums into consideration for PATTERN_NEVER_MATCHES_VALUE_TYPE. #53394

Open alexmarkov opened 1 year ago

alexmarkov commented 1 year ago

There are new test failures on add Builder.report method and Diagnostic class to support macros sending diagnostics...Issue 53287. Include enums into consideration for PATTERN_NEVER_MATCHES_VALUE_TYPE..

The tests

vm/cc/Profiler_ChainedSamples Crash (expected Pass)

are failing on configurations

vm-linux-release-riscv64-qemu

Log:

--- Command "run_vm_unittest" (took 19.000732s):
DART_CONFIGURATION=ReleaseXRISCV64 qemu-riscv64 -L /usr/riscv64-linux-gnu/ out/ReleaseXRISCV64/run_vm_tests --dfe=/b/s/w/ir/cache/builder/sdk/out/ReleaseXRISCV64/gen/kernel_service.dill --enable-experiment=records --sound-null-safety --ignore-unrecognized-flags Profiler_ChainedSamples

exit code:
-6

stdout:
Running test: Profiler_ChainedSamples

stderr:
===== CRASH =====
si_signo=Segmentation fault(11), si_code=1, si_addr=(nil)
version=3.2.0-edge.abc7a216795e4bb43d50d958213f04d25253d4b6 (be) (Wed Aug 30 17:43:42 2023 +0000) on "linux_riscv64"
pid=41537, thread=41562, isolate_group=kernel-service(0x400c000f70), isolate=(nil)((nil))
os=linux, arch=riscv64, comp=no, sim=no
isolate_instructions=0, vm_instructions=61be20
fp=0, sp=0, pc=2
Stack dump aborted because GetAndValidateThreadStackBounds failed.
  pc 0x0000000000000002 fp 0x0000000000000000 Unknown symbol
=== Crash occurred when compiling package:front_end/src/fasta/dill/dill_class_builder.dart_DillClassBuilder_addProcedure in optimizing JIT mode in unknown pass
=== Flow Graph not available

--- Re-run this test:
python3 tools/test.py -n vm-linux-release-riscv64-qemu vm/cc/Profiler_ChainedSamples

https://dart-ci.appspot.com/log/vm-ffi-qemu-linux-release-riscv64/vm-linux-release-riscv64-qemu/686/vm/cc/Profiler_ChainedSamples

alexmarkov commented 1 year ago

This test seems to be flaky on RISC-V, flipping between Pass, Crash and flaky:

https://dart-ci.firebaseapp.com/#showLatestFailures=false&configurations=vm-linux-release-riscv64-qemu&test=vm/cc/Profiler_ChainedSamples

/cc @rmacnak-google