search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.21k stars 1.57k forks source link

Missing compile time errors for native syntax #54153

Open mraleph opened 11 months ago

mraleph commented 11 months ago

Tests from language/syntax/syntax_native_test are failing on CFE due to missing compile time errors.

Maybe we should delete the test if we don't care?

/cc @johnniwinther

whesse commented 6 months ago

The test also runs on vm and compiles with dart2js with no errors, indicating that the responsibility of detecting the use of "native" in non-sdk libraries should be on CFE. (Analyzer correctly reports them).

I have made a CL converting this multitest to a static error test, so it doesn't run on vm and web runtimes. I am adding error expectations for CFE, so that it continues to fail on CFE with missing compile-time errors.

CL: https://dart-review.googlesource.com/c/sdk/+/363085