`writeln` is not thread-safe

[ntkme]

https://github.com/dart-lang/sdk/commit/1d3d819ecfa2000ed11a137f5ee80df5bb687819 only partially fixed https://github.com/dart-lang/sdk/issues/53471, that the print function is now thread safe. However. stdout.writeln and stderr.writeln are still not thread safe.

stdout.writeln can be replaced with print in most cases, however, stderr.writeln does not have a thread-safe alternative.

import 'dart:isolate';
import 'dart:io';

void main() {
  Future.wait([
    for (var i = 0; i < 100; i += 1)
      Isolate.run(() {
        stdout.writeln('test');
      })
  ]);
}

@a-siva

[lrhn]

Must it be?

I'd personally accept any interleaving of the characters emitted by the isolates, as long as the ones from a single isolate are in the correct order. The Posix standard does require individual calls to be flock-ing on the FILE*, but we haven't promised that writeln is atomic, or that it's one Posix call.

If it's easy and cheap to fix, we should probably do it, just for the convenience. If not, maybe it just needs a disclaimer.

[ntkme]

We already made print behave this way. I guess it shouldn't be too hard to make writeln for at least stdout and stderr behave the same way.