search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.59k forks source link

[Wildcard Variables] VS Code Support #55726

Closed kallentu closed 5 months ago

kallentu commented 6 months ago

This issue tracks the wildcard variables work needed for VS Code. If no work needs to be done, feel free to close it.

cc @jwren

DanTup commented 5 months ago

I don't think there's any work for either VS Code of the textmate grammar, unless we perhaps want to color _ differently to normal variables (for semantic tokens this would be done in the analysis servers highlights, but for the textmate grammar we don't currently colour variables at all because it's not a complete grammar).

cc @bwilkerson in case he can think of anything else I've overlooked.

bwilkerson commented 5 months ago

No, I can't think of anything. The grammar hasn't changed, so most other tooling ought to not be impacted.

... unless we perhaps want to color _ differently to normal variables ...

I don't think we're currently coloring wildcard patterns differently, and I would expect that we'd want to color all wildcards the same way.

DanTup commented 5 months ago

Makes sense, closing this as nothing to do then. Thanks!