Closed kallentu closed 1 month ago
One potential work item that came up from the discussion between the VM and CFE team this afternoon
It is possible something similar would be needed on the web side too.
@kallentu It will be helpful if the CFE can provide predicates to identify which variables are created by the lowering for wildcards. We already have other predicates for other lowerings in this file: https://github.com/dart-lang/sdk/blob/main/pkg/front_end/lib/src/api_prototype/lowering_predicates.dart
@kallentu It will be helpful if the CFE can provide predicates to identify which variables are created by the lowering for wildcards. We already have other predicates for other lowerings in this file: https://github.com/dart-lang/sdk/blob/main/pkg/front_end/lib/src/api_prototype/lowering_predicates.dart
Noted. Haven't changed CFE to have unique lowered names yet. I'll comment on this issue again when I make progress.
The CL that lowers wildcard variable names into unique names https://github.com/dart-lang/sdk/commit/1d527619505dbce25a2822951f84294a14584b57 has now been submitted.
https://github.com/dart-lang/sdk/blob/main/pkg/front_end/lib/src/kernel/wildcard_lowering.dart are where the wildcard predicates and name conversions are located.
These predicates are exported by https://github.com/dart-lang/sdk/blob/main/pkg/front_end/lib/src/api_prototype/lowering_predicates.dart so you should get them if you already import this file.
Let me know if you need anything else or anything should be changed. Happy to do so.
Otherwise, CFE implementation is complete and ready for any web debugging work.
Looks like wildcards are being hidden correctly on web:
This issue tracks the web debugging support needed for the wildcards feature.
References
Originally posted by @sigmundch in #55751
cc. @nshahan @bkonyi