dart-github-bot
commented
1 month ago Summary: DevTools 2.37.1 has two issues: overlapping disconnected views messaging and incorrect categorization of Socket traffic as WebSocket data. This cherry-pick release fixes these issues, improving the user experience for debugging sessions and network profiling.
itsjustkevin
Commit(s) to merge
https://dart-review.googlesource.com/c/sdk/+/376123
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/376123
Issue Description
In the most recent DevTools release 2.37.1, there are two issues that we need to fix in anticipation of the upcoming stable: 1) DevTools was displaying two overlapping disconnected views messaging when an app disconnects. 2) Network traffic for Sockets is improperly categorized as WebSocket data and displays incorrect content.
What is the fix
Release a cherry-pick release of DevTools into the Dart / Flutter SDKs that includes 2 commits on top of the previous release: https://github.com/flutter/devtools/compare/v2.37.1...2.37.2
These two commits 1) fix the overlapping UI on disconnect: https://github.com/flutter/devtools/commit/9e752ce2064e3390ef4b10663a2a8bb6f43ebbb8 2) fix the issue where socket profile data was being displayed as web socket connections: https://github.com/flutter/devtools/commit/f440b48fa2dfe22e806ebe64791d84a2e5b8b2fa
Why cherry-pick
1) This will affect the embedded IDE use case greatly since users are often killing and restarting debug sessions and DevTools should gracefully handle disconnects and reconnects. 2) The network page is difficult to use and confusing for Socket traffic without this change. We have several users blocked by this broken experience. The issue had 10 upvotes, several other duplicate issues filed, and chatter on Discord.
Risk
Low.
Issue link(s)
https://github.com/flutter/devtools/issues/8050, https://github.com/flutter/devtools/issues/3033
Extra Info
It is also important the this cherry-pick be approved in tandem with https://github.com/dart-lang/sdk/issues/56273, which is a CP that fixes a data issue in dart:io that contributed to the poor experience DevTools users were seeing in the DevTools network page.