dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.19k stars 1.57k forks source link

vm/dart/isolates/shared_primitives_test changing from flaky to RTE on vm-reload-linux-debug-x64 #56277

Closed sstrickl closed 2 months ago

sstrickl commented 2 months ago

There are new test failures on [wildcards] Call Hierarchy target tests...[cfe] Move scope/exportScope to Dill/SourceLibraryBuilder.

The tests

vm/dart/isolates/shared_primitives_test RuntimeError (expected Pass)

are failing on configurations

vm-reload-linux-debug-x64

Looking at the history and the flakiness dashboard, the test has been flaky on this configuration and on vm-reload-rollback-linux-debug-x64 since it was added in d2bc05565. Looking at the [log](), the error is in the exitCode check that's gated by a version contains check:

--- Command "vm" (took 02:06.000435s):
DART_CONFIGURATION=DebugX64 out/DebugX64/dart --hot-reload-test-mode --sound-null-safety -Dtest_runner.configuration=vm-reload-linux-debug-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/runtime/tests/vm/dart/isolates/shared_primitives_test.dart

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
Expect.equals(expected: <0>, actual: <255>) fails.
#0      Expect._fail (package:expect/expect.dart:881:5)
#1      Expect._failNotEqual (package:expect/expect.dart:174:5)
#2      Expect.equals (package:expect/expect.dart:157:5)
#3      main (file:///b/s/w/ir/runtime/tests/vm/dart/isolates/shared_primitives_test.dart:78:16)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n vm-reload-linux-debug-x64 vm/dart/isolates/shared_primitives_test

The same failure also shows up in the RTE entries in the flakiness dashboard for vm-reload-rollback-linux-debug-x64.

dart-github-bot commented 2 months ago

Summary: The shared_primitives_test on vm-reload-linux-debug-x64 configuration has transitioned from flaky to a runtime error (RTE). The test fails due to an exitCode mismatch, where the expected value is 0 but the actual value is 255. This issue has been present since the test was added and is also observed in the flakiness dashboard for vm-reload-rollback-linux-debug-x64.

alexmarkov commented 2 months ago

Similarly, vm/dart/isolates/shared_primitives_test turned flaky -> RuntimeError on vm-reload-rollback-linux-debug-x64:

--- Command "vm" (took 01:59.000790s):
DART_CONFIGURATION=DebugX64 out/DebugX64/dart --hot-reload-rollback-test-mode --sound-null-safety -Dtest_runner.configuration=vm-reload-rollback-linux-debug-x64 --ignore-unrecognized-flags --packages=/b/s/w/ir/.dart_tool/package_config.json /b/s/w/ir/runtime/tests/vm/dart/isolates/shared_primitives_test.dart

exit code:
255

stdout:
unittest-suite-wait-for-done

stderr:
Unhandled exception:
Expect.equals(expected: <0>, actual: <255>) fails.
#0      Expect._fail (package:expect/expect.dart:881:5)
#1      Expect._failNotEqual (package:expect/expect.dart:174:5)
#2      Expect.equals (package:expect/expect.dart:157:5)
#3      main (file:///b/s/w/ir/runtime/tests/vm/dart/isolates/shared_primitives_test.dart:78:16)
<asynchronous suspension>

--- Re-run this test:
python3 tools/test.py -n vm-reload-rollback-linux-debug-x64 vm/dart/isolates/shared_primitives_test

https://dart-ci.appspot.com/log/vm-reload-rollback-linux-debug-x64/vm-reload-rollback-linux-debug-x64/492/vm/dart/isolates/shared_primitives_test