Failures on Make async error injection set stack trace on errors.

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.

https://dart.dev

BSD 3-Clause "New" or "Revised" License

10.2k stars 1.57k forks source link

Failures on Make async error injection set stack trace on errors. #56585

Closed liamappelbe closed 1 month ago

liamappelbe commented 1 month ago

There are new test failures on Make async error injection set stack trace on errors..

The tests

vm/dart/isolates/concurrency_stress_sanity_test RuntimeError (expected Pass)

are failing on configurations

vm-appjit-linux-release-x64
vm-linux-release-x64

Log: https://dart-ci.appspot.com/log/vm-linux-release-x64/vm-linux-release-x64/3737/vm/dart/isolates/concurrency_stress_sanity_test

Looks like some of the tests that were deleted are still referenced here.

dart-github-bot commented 1 month ago

Summary: The "Make async error injection set stack trace on errors" commit introduced test failures in the concurrency_stress_sanity_test on Linux x64 configurations. The failures are likely due to references to deleted tests.

dcharkes commented 1 month ago

https://dart-review.googlesource.com/c/sdk/+/382561