Renaming files should also fix `directives_ordering`

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.

https://dart.dev

BSD 3-Clause "New" or "Revised" License

10.3k stars 1.59k forks source link

Renaming files should also fix `directives_ordering` #56739

Open FMorschel opened 2 months ago

FMorschel commented 2 months ago

Repro:

Create a new empty project
Make sure you have directives_ordering set to true inside analysis_options
Add two files a.dart and b.dart
Add both imports to main.dart (respecting directives_ordering)
Rename a.dart to c.dart
See that on main.dart you get the directives_ordering lint on the line that now is c.dart

// CC: @DanTup

dart-github-bot commented 2 months ago

Summary: Renaming a file that is imported in a Dart file does not update the import path in the file, leading to a directives_ordering lint error. This issue occurs even when the directives_ordering rule is enabled in the analysis_options file.