search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.2k stars 1.57k forks source link

dart2dart minified - method not found: 'cos' #5674

Closed DartBot closed 9 years ago

DartBot commented 12 years ago

This issue was originally filed by @bp74

What steps will reproduce the problem?

I don't know if it makes sense to send reports for dart2dart because it is very early in the process, but here is my issue. I have minified this project:

https://github.com/bp74/dartflash-escape

What is the expected output? What do you see instead? The minified dart-code went from appr. 259KB to 55KB which is great! It looks like real minified code, very cool :) the output is attached to this issue.

But unfortunately, the program does not run, i get this error:   NoSuchMethodError : method not found: 'cos'   Receiver: 400   Arguments: [0.1382300767579509]

What version of the product are you using? On what operating system?

Windows 7 64 Bit, Dart Editor Build 13294, SDK Build 13292

Please provide any additional information below.

Attachment: out.dart (54.14 KB)

DartBot commented 12 years ago

This comment was originally written by @bp74

Maybe another issue: compiling the "out.dart" to JavaScript throws a compiler error, but this may be somehow related to the problem described above.

Running dart2js... /D:/GitHub/bp74/dartflash-escape/web/out.dart:1:48103: Error: method cannot override field 'y' of 'V'.

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

Bernhard, we definitely appreciate any bug reports, so thank you very much!

Roma, may you have a look, please?

Set owner to smok@google.com. Added this to the M1 milestone. Added Area-Dart2Dart, Triaged labels.

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

I think I know what goes on here, stealing

Set owner to antonm@google.com. Added Started label.

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

I've got a fix pending. The only problem, we all won't be available early next week, so, please, expect the fix on approx Wed of the next week.

DartBot commented 12 years ago

This comment was originally written by @bp74

Thank you very much, there is no need for hurry. Great that you have found the problem so fast! I imagine it's not easy to find problems in minified code :)

DartBot commented 12 years ago

This comment was originally written by antonm@google.com

Should be fixed now, please, reopen if not.

Added Fixed label.