search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

riscv32 build is broken #57021

Closed aam closed 2 weeks ago

aam commented 2 weeks ago

https://dart-review.googlesource.com/c/sdk/+/392740 broke riscv32 build. 

$ tools/build.py -mrelease -asimriscv32 dart gen_snapshot create_sdk
...
../../runtime/vm/compiler/backend/il_riscv.cc:6878:14: error: unused variable 'in_hi' [-Werror,-Wunused-variable]
 6878 |     Register in_hi = in_pair->At(1).reg();
      |              ^~~~~
1 error generated.

This showed up as broken fuzz bot https://ci.chromium.org/ui/b/8732415745790097697

cc @alexmarkov

alexmarkov commented 2 weeks ago

@aam Un-assigned the issue from myself as I saw your fix https://dart-review.googlesource.com/c/sdk/+/393361.

@rmacnak-google What is the status of 32-bit RISC-V support? If we support it, should we have at least one (nightly?) bot for testing it? Fuzz bot doesn't send e-mails and doesn't have a corresponding try-bot which would prevent such trivial compilation errors.

aam commented 2 weeks ago

I have put together https://dart-review.googlesource.com/c/sdk/+/393380 that adds simriscv32 to nightly builds