search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

Failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime...." and "...[dart2wasm] Improve ClassInfo field validation error messages #57055

Closed jyameo closed 1 week ago

jyameo commented 2 weeks ago

There are new test failures on Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory""...[dart2wasm] Improve ClassInfo field validation error messages.

The tests

hot_reload/delete_static_field Fail (expected Pass)
hot_reload/existing_static_field_changes_type_indirect_function Fail (expected Pass)
hot_reload/existing_static_field_changes_type_indirect_generic Fail (expected Pass)
standalone/io/unix_socket_test RuntimeError (expected Pass)

are failing on configurations

ddc-canary-linux-chrome
vm-reload-linux-release-x64

LOGS:

CC @bkonyi @derekxu16 @a-siva

dart-github-bot commented 2 weeks ago

Summary: The reland of "[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime" and "[dart2wasm] Improve ClassInfo field validation error messages" introduced test failures in hot reload and standalone/io/unix_socket_test on ddc-canary-linux-chrome and vm-reload-linux-release-x64 configurations.

a-siva commented 2 weeks ago

These failures seem unrelated to the changes. It looks like the tests are flaky

bkonyi commented 1 week ago

FYI @natebiggs for the failing / flaky DDC hot reload tests.

nshahan commented 1 week ago

cc @Markzipan

The following tests were added by https://github.com/dart-lang/sdk/commit/5b0128565cd1fe41504df42a0291f474f8a5619e which is within the range of flagged CLs. The failures on ddc-canary-linux-chrome are expected at this time.

hot_reload/delete_static_field
hot_reload/existing_static_field_changes_type_indirect_function
hot_reload/existing_static_field_changes_type_indirect_generic
a-siva commented 1 week ago

I think we can close this issue as I presume the hot reload test failures on the web are being tracked