search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

Fix false positive fix remove ? #57068

Closed tenhobi closed 1 week ago

tenhobi commented 2 weeks ago

Fixes #57067

Does not suggest to remove ? when type is not resolved (is InvalidType).

copybara-service[bot] commented 2 weeks ago

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/394403

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394403 has been updated with the latest commits from this pull request.