dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

fix: do not add trailing commit the last positional parameter already… #57069

Open a-wallen opened 1 week ago

a-wallen commented 1 week ago

… has one


Contribution guidelines:
- See our [contributor guide](https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.
copybara-service[bot] commented 1 week ago

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/394660

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

a-wallen commented 1 week ago

https://critique.corp.google.com/cl/695463353

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394660 has been updated with the latest commits from this pull request.

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394660 has been updated with the latest commits from this pull request.