search

dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

[vm] Compile binaryen on C++17 #57075

Closed ntkme closed 1 week ago

ntkme commented 1 week ago

Binaryen's README mentions that it currently requires C++17: https://github.com/WebAssembly/binaryen#:~:text=A%20C%2B%2B17%20compiler%20is%20required.

Closes #57074.

copybara-service[bot] commented 1 week ago

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/394920

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

ntkme commented 1 week ago

cc @rmacnak-google

copybara-service[bot] commented 1 week ago

https://dart-review.googlesource.com/c/sdk/+/394920 has been updated with the latest commits from this pull request.