dart-lang / sdk

The Dart SDK, including the VM, JS and Wasm compilers, analysis, core libraries, and more.
https://dart.dev
BSD 3-Clause "New" or "Revised" License
10.28k stars 1.58k forks source link

[analysis_server] "Your project contains issues that can be fixed automatically" notification is shown even when I click "don't show again" #57081

Closed incendial closed 1 week ago

incendial commented 1 week ago

Every time I restart the IDE I get the "Your project contains issues that can be fixed automatically." notification shown even if I click the "Don't show again" button. The ".prompts" folder is not updated since August 7th, so for some reason the state of this button is not saved on FS.

Dart SDK version: 3.5.4 (stable) (Wed Oct 16 16:18:51 2024 +0000) on "macos_x64"

@DanTup fyi.

dart-github-bot commented 1 week ago

Summary: The "Your project contains issues that can be fixed automatically" notification reappears after restarting the IDE, even after clicking "Don't show again." The notification's state is not being saved to the ".prompts" folder, suggesting a file system issue.

devoncarew commented 1 week ago

Thanks for the report! I think this issue might be with the vs-code plugin however (https://github.com/Dart-Code/Dart-Code).

DanTup commented 1 week ago

This prompt actually comes from the analysis server (via the showMessageRequest API), since it does the check for whether there are any fixable issues.

It's supposed to persist a file to suppress the prompts when you click "Don't show again" though, sounds like this might not be working correctly.

devoncarew commented 1 week ago

This prompt actually comes from the analysis server (via the showMessageRequest API) ..

Ah, gotcha.

DanTup commented 1 week ago

@incendial I can reproduce this on stable, but not on bleeding-edge. I recalled looking at it recently, and it turns out it that was after the branch for Dart 2.4. So it has been fixed and will be included in the next main (non-hotfix) release: