Closed stephane-archer closed 6 days ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:
https://dart-review.googlesource.com/c/sdk/+/395260
Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.
Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).
Thanks for the PR but this is just an equivalent to stat.mode.toRadixString(8)
. I don't think there is any need to add it as a separate method. Also it is a breaking change for anything implementing the FileStat
class.
I was not aware of "stat.mode.toRadixString(8)" is it exactly equivalent?
I guess you might also need to mask things if you don't care about top bits: (stat.mode & 0x1FF).toRadixString(8)
add modeOctalString to FileStat for compatibility with Posix tools